Netflix-Skunkworks / atlas-system-agent

Agent that reports system metrics through SpectatorD.
Apache License 2.0
5 stars 8 forks source link

Fix `titus.host` metric tag #99

Closed copperlight closed 3 years ago

copperlight commented 3 years ago

https://github.com/Netflix-Skunkworks/atlas-system-agent/blob/4d0eb3fce8d122835cedc3d09a744e0510e2ffbe/bin/atlas-agent.cc#L296-L299

Before, when this agent was not a Titus System Service, it reported the EC2_INSTANCE_ID of the host system. Since we switched to running as a system service, it now reports the task id. Currently, there is not an env var available in the containers that reflects the host instance id.

We should either remove this tag, or get a new env var added which has this information.

copperlight commented 3 years ago

https://github.com/Netflix/titus-executor/pull/676

The new variable is TITUS_HOST_EC2_INSTANCE_ID.