search

Netflix-Skunkworks / cloudaux

Cloud Auxiliary is a python wrapper and orchestration module for interacting with cloud providers
Apache License 2.0
76 stars 44 forks source link

Added ExternalId to sts.assume_role calls. #84

Closed dgreene-r7 closed 6 years ago

dgreene-r7 commented 6 years ago

This PR adds an optional ExternalId to all sts.assume_role calls.

See https://github.com/Netflix/security_monkey/pull/1101 and https://github.com/Netflix/security_monkey/issues/1100.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 17.131% when pulling d9f60b93578ca4f0a93dd7c2a21e08d77baf0da8 on dgreene-r7:add-external-id-to-sts-assume-role into b509c29d864497d536996bd772a629645ff75f32 on Netflix-Skunkworks:master.

mikegrima commented 6 years ago

LGTM. Were you able to test that this works?

dgreene-r7 commented 6 years ago

I tested it briefly in a REPL using some of the examples in the README and it works as far as I can tell.

mikegrima commented 6 years ago

Please bump up the version number in __about__.py.

After that, update the SM requirements to pin to that version.

dgreene-r7 commented 6 years ago

Minor or patch?

mikegrima commented 6 years ago

1.5.0.

mikegrima commented 6 years ago

Pushed 1.5.0 to PyPI.