Move to styled-components

Netflix-Skunkworks / commuter

🚎 Notebook sharing hub

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

Move to styled-components #4

Closed mpacer closed 5 years ago

mpacer commented 5 years ago

Move away from styled-jsx to styled components

[x] view(M )
[x] header (M )
[x] text (M )
[x] directory-listing (M )
[x] browse-header (M )
[x] zeppelin (Shelby )
[x] clone (Shelby )
[x] ~discover (Shelby )~ discover was removed

mpacer commented 5 years ago

@stormpython @rgbkrk

stormpython commented 5 years ago

@mpacer ok, I will checkout your branch, add the last 3 files today.

rgbkrk commented 5 years ago

Ok, with our current PRs in flight we're all set internally once those are merged. We still need to upgrade the components we're using so that we are using the newer @nteract/* components all use styled-components rather than the older versions that relied on styled-jsx. Progress for that is in #5.

stormpython commented 5 years ago

I want to make sure I am linking to the PRs in order to track comments and changes, etc.

Links to PRs for zeppelin & clone.

rgbkrk commented 5 years ago

Looks like we're all set here!