Netflix-Skunkworks / commuter

🚎 Notebook sharing hub
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Upgrade nteract dependencies #5

Open rgbkrk opened 5 years ago

rgbkrk commented 5 years ago

It would be good for us to match the nteract/nteract deps for components as much as possible, so our rendering is consistent.

rgbkrk commented 5 years ago

Uh oh... I just noticed notebook-preview no longer exists as a component. I'm going to have to go nteract spelunking.

rgbkrk commented 5 years ago

Alright, I'm back on this.

rgbkrk commented 5 years ago

My first step for this was separating our notebook usage out of components/contents/index.js into components/contents/notebook.js. The next step is re-implementing <NotebookPreview /> on top of the nteract components currently released. This likely requires an upgrade to React, as mentioned in #8.

rgbkrk commented 5 years ago

Since I'll probably need to convert each individual page to typescript that uses an nteract component, I'm going to do each of these PRs as small ones. The first one up is the directory listing.