Netflix-Skunkworks / raven-python-lambda

Sentry/Raven SDK Integration For AWS Lambda (python) and Serverless
Apache License 2.0
47 stars 15 forks source link

Passed in configuration values are overridden by the defaults #10

Closed bjorn-spire closed 7 years ago

bjorn-spire commented 7 years ago

I wanted to override the default log level sent to Sentry, so I decided to set logging=False and pass that into the wrapper. But I noticed that Sentry was still receiving INFO messages and when digging around the code I noticed this:

self.config.update(config_defaults)

It seems like it should be the other way around to work, config_defaults should be updated with self.config.

Right now I'm working around this by setting the environment variable SENTRY_CAPTURE_LOGS to an empty string since that's falsy in Python, but I see there's another PR that would let me pass in false instead. :)