Netflix-Skunkworks / raven-python-lambda

Sentry/Raven SDK Integration For AWS Lambda (python) and Serverless
Apache License 2.0
47 stars 15 forks source link

Allow calling Lambda from an Application Load Balancer (ALB) #41

Open bjorn-spire opened 5 years ago

bjorn-spire commented 5 years ago

You can use lambda together with Application Load Balancer (ALB) which uses a different set of keys than previously set. This change makes more checks to ensure that when trying to use more keys then they exist (or, at least one of the keys exist and we assume it's a representative sample).

I also went ahead and added py37 support to tox since it's available in Lambda these days.

And with a PR a cute animal picture, this is a culogo or flying lemur! :D colugo - a flying lemur

bjorn-spire commented 5 years ago

I don't understand the Travis error, I don't understand why it would complain about Google Compute Engine?

ConftestImportFailure: (local('/home/travis/build/Netflix-Skunkworks/raven-python-lambda/raven_python_lambda/tests/conftest.py'), (<type 'exceptions.ImportError'>, ImportError('No module named google_compute_engine',), <traceback object at 0x7f8bee004488>))
bjorn-spire commented 5 years ago

Okay, seems to be something with boto having it in there. I can't replicate it locally :( Seem to be generally running the same versions and tox across py27, py36, and py37 works. Maybe one of you core maintainers know what this may be about?

bjorn-spire commented 5 years ago

Okay, so I couldn't leave it be and it seems to be because of some weird Travis configuration: https://github.com/travis-ci/travis-ci/issues/7940

By adding a step to remove /etc/boto.cfg before running all the tests they're running again.