Netflix-Skunkworks / service-capacity-modeling

Apache License 2.0
67 stars 19 forks source link

Add cpu utilization as a parameter with which desires can be obtained #74

Closed ramsrivatsa closed 1 year ago

ramsrivatsa commented 1 year ago

Use CPU utilization directly within extra model arguments. If we have utilization numbers, we can directly leverage them to obtain desired instance types. If we don't, then use the default reads and writes to compute CPU util which in turn can be used to obtain desired instance types.

Also added pytest in the setup so that it can integrate seamlessly with pycharm.

abersnaze commented 1 year ago

i noticed a lot of whitespace change. @jolynch what is there a formatter that you used?

abersnaze commented 1 year ago

I don't think the model should be aware what the current instance is.

I would like to see the current instance to be used as signal to the planner that one of the least_regret plans must be of that instance. that way we could:

this also introduces more challenges to compositions of models since a kv cluster would likely have a different current instance than the composed cassandra. I'm thinking we should depreciate composition and have the client invoke the planner for each model separately.