search

Netflix / CassJMeter

JMeter plugin to run cassandra tests.
Apache License 2.0
163 stars 66 forks source link

inverted assert #1

Closed mdione-orange closed 11 years ago

mdione-orange commented 12 years ago

https://github.com/Netflix/CassJMeter/blob/master/src/main/java/com/netflix/jmeter/sampler/Connection.java#L52

this line asserts that there are no servers configured! also, the method assumes the port to use for all the servers is the port configures in the last server defined.

jasobrown commented 11 years ago

Fixed the assert with commit 725bb73e4fbd5bf5b79ff47a3db1c59ccd1ebf0e. Yes, it was indeed incorrect (please see note on commit).

About the port assumed to be the same: in theory, yes, you are assuming 'last one in wins'. However, I'm not sure that people run cassandra clusters with different port configured between them. Hence, I'm going to let that slide.