Netflix / Hystrix

Hystrix is a latency and fault tolerance library designed to isolate points of access to remote systems, services and 3rd party libraries, stop cascading failure and enable resilience in complex distributed systems where failure is inevitable.
23.98k stars 4.7k forks source link

`HystrixCircuitBreaker` does not take the `forceOpen` property into account after 1.5.13 #1952

Open fuleow opened 5 years ago

fuleow commented 5 years ago

I updated hystrix-core from version 1.5.13 to 1.5.18 and our circuit breaker unit test started failing. Upon investigation I noticed there was a change in HystrixCircuitBreaker and it no longer reads the value of forceOpen.

Checking the history it seems that this was changed in 1.5.14

1.5.13 1.5.14

Is this an unintended regression? The history shows some commits in 2017 that was removed. https://github.com/Netflix/Hystrix/commits/v1.5.13/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCircuitBreaker.java https://github.com/Netflix/Hystrix/commits/v1.5.14/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCircuitBreaker.java