Netflix / PigPen

Map-Reduce for Clojure
Apache License 2.0
565 stars 55 forks source link

Bump clj-time version to 0.8.0 #76

Closed juskrey closed 9 years ago

juskrey commented 9 years ago

Old clj-time version produces a nasty issue in case new version of the lib is used along with PigPen. See https://github.com/clj-time/clj-time/issues/124

Some tests were failing due to the fact Clojure maps are not guaranteed to preserve kv pairs order. Array- map are doing that. What structure behaviour to choose is up to the developer.

mbossenbroek commented 9 years ago

Looked some more & this does pull 1.6.0. I tried last week to upgrade to 1.6.0, but ran into some build/jar issue with instaparse that I don't remember now...

Were you able to run this on a hadoop cluster?

Longer term I plan to get rid of these dependencies altogether. I barely use them anyway.

juskrey commented 9 years ago

Yes, this thing is working for me after fresh gradle build and fresh uberjar, clojure 1.6.0. On AMR cluster. I have instaparse linking issues with 1.7.0-alphas

On Fri, Sep 19, 2014 at 7:58 PM, Matt Bossenbroek notifications@github.com wrote:

Looked some more & this does pull 1.6.0. I tried last week to upgrade to 1.6.0, but ran into some build/jar issue with instaparse that I don't remember now...

Were you able to run this on a hadoop cluster?

Longer term I plan to get rid of these dependencies altogether. I barely use them anyway.

— Reply to this email directly or view it on GitHub https://github.com/Netflix/PigPen/pull/76#issuecomment-56204530.

mbossenbroek commented 9 years ago

Pulled this in today & resolved the issue I was seeing before with 1.6.0. Turned out it was something loading weird in CCW, but fixed it nonetheless.

I went to try it out on our clusters & ran into some weird locking problem with the local mode. I'm going to try to merge the rx upgrade that was pending & give it another try after that.

I'm also removing the code that needed instaparse & clj-time, so these won't be a problem going forward either.

mbossenbroek commented 9 years ago

Fixed by #78 - version 0.2.10