search

Netflix / Priam

Co-Process for backup/recovery, Token Management, and Centralized Configuration management for Cassandra.
Apache License 2.0
1.03k stars 294 forks source link

Unreleased Resource: Streams #905

Open QiAnXinCodeSafe opened 3 years ago

QiAnXinCodeSafe commented 3 years ago

https://github.com/Netflix/Priam/blob/a78b203c5031e791aa1372938effc4c626b7b9a5/priam/src/main/java/com/netflix/priam/tuner/dse/DseTuner.java#L69

The program can potentially fail to release a system resource.

mattl-netflix commented 3 years ago

My take: the faster Priam starts and the more durable it is the more value it adds. Saying up at all costs is a key design goal. So we'll happily take the risk of keeping some system resource open to avoid a noisy delay at startup. Also, given that this code is only relevant at startup, we're only at risk of having this one file handle open in any one session.