Netflix / Turbine

SSE Stream Aggregator
Apache License 2.0
835 stars 255 forks source link

Instance monitor init() giving response code other then 200 without response message #117

Open JagmohanSharma opened 7 years ago

JagmohanSharma commented 7 years ago

@ryanjbaxter and @spencergibb Reference to another misplaced issue https://github.com/spring-cloud/spring-cloud-netflix/issues/1631

which is closed to have discussion on the right place as in turbine-core.

JagmohanSharma commented 7 years ago

https://github.com/spring-cloud/spring-cloud-netflix/issues/1631

JagmohanSharma commented 7 years ago

Can somebody help in this issue? it bit urgent to get it resolved for us. Or tell me if this contains wrong information or at wrong place to be asked?

JagmohanSharma commented 7 years ago

Please let me know if it not allowed to post issues here?

spencergibb commented 7 years ago

Turbine isn't maintained much anymore.

JagmohanSharma commented 7 years ago

I got one more issue here , as while reading stream through /turbine.stream endpoint for any cluster , if user close this through browser , it throws ClientAbortException with message as "java.io.IOException: Broken pipe". Now as in TurbineStreamingConnection as we have catch block to handle this and we are checking as

                                   catch (Exception e) {
                                      if ("Broken pipe".equals(e.getMessage())) { 
                                    // use debug instead of error as this is expected to happen every time a client            
                                   disconnects
                               logger.debug("Broken pipe (most likely client disconnected) when writing to                   
                                     response  stream", e);
                                    } else {
                                   logger.error("Got exception when writing to response stream", e);
                               }
                                 stopMonitoring = true;
                             }

Here shouldn't we have checked for contains instead of equals for exception message "broken pipe" as (e.getMessage()).contains("Broken pipe") so it will be true for above mentioned message as "java.io.IOException: Broken pipe". This should be addressed in turbine as in our application we have email notification for all error log message and in this situation this is causing unrelevant email notification by wrong condition check.

Let me know if I have mis interpreted this.

Thanks.

JagmohanSharma commented 7 years ago

if this project is not being maintained then how would issues with this be resolved? As many would be using turbine application to have an aggregated view of hystrix circuit breaker dashboard.

Or is there any way to get the same functionality without using Turbine anymore?