search

Netflix / Turbine

SSE Stream Aggregator
Apache License 2.0
835 stars 255 forks source link

Added support for aggregating streams protected by basic auth #93

Closed johanhaleby closed 9 years ago

johanhaleby commented 9 years ago

It's now possible to specify streams like http://username:password@mydomain.org. Username and password is applied as basic auth.

For example -streams "http://johan:password@mydomain.org"

benjchristensen commented 9 years ago

Thank you for contributing this. Changes look good to me.

Are you able to share information on your usage of Turbine 2.x? It's still not broadly talked about or used, since I created it primarily for the community and not internal Netflix usage (we have a bigger stream processing system now).

spencergibb commented 9 years ago

@benjchristensen Spring Cloud Netflix uses turbine 2 for aggregating hystrix streams via rabbitmq. I'm curious, what is you bigger stream processing system?

johanhaleby commented 9 years ago

@benjchristensen We're currently not using it but we're thinking of doing so and that's why we need this feature (as well as SSL support which I'm currently working on). We're using Spring Cloud Hystrix which expose the Hystrix stream from the "management console" which is protected by basic auth. Since we have a couple of different services using Hystrix we figure we'd be using Turbine to combine them into single stream and hook up the Hystrix Dashboard to this stream. I suppose we would need some discovery mechanism as well later.