search

Netflix / archaius

Library for configuration management API
Apache License 2.0
2.46k stars 485 forks source link

Update handling for parameterized methods via ConfigProxyFactory #680

Closed akang31 closed 11 months ago

akang31 commented 11 months ago

Currently, even if a top level prefix is specified in an @Configuration annotation, parameterized methods in the body will ignore the prefix.

This change updates this behavior to properly acknowledge the prefix annotation.

This is notably breaking, so we keep backward compatibility for users who compensated by having their parameterized methods include the prefix. However, we will be breaking users that did not include the prefix.

Putting this up for review now, but still following up with a few clients to ensure the safety of this change.

rgallardo-netflix commented 11 months ago

Looks good, let's wait for those users' feedback.

akang31 commented 11 months ago

I've received confirmation from the users that this change will not affect them (the properties were either unused, or in decommissioned applications)

rgallardo-netflix commented 11 months ago

👍 Let's merge, then. But also, since there's a visible behavior change, let's remember to bump the next release's minor version to 2.6