Netflix / asgard

[Asgard is deprecated at Netflix. We use Spinnaker ( www.spinnaker.io ).] Web interface for application deployments and cloud management in Amazon Web Services (AWS). Binary download: http://github.com/Netflix/asgard/releases
http://netflix.github.com/asgard
Apache License 2.0
2.24k stars 403 forks source link

Fix #602. #670

Closed csm closed 7 years ago

csm commented 9 years ago

Fixes #602.

cloudbees-pull-request-builder commented 9 years ago

asgard-pull-requests #495 FAILURE Looks like there's a problem with this pull request

csm commented 9 years ago

I don't have any idea what failed, there aren't any details.

Note that this is against the 1.5.1 tag, so that could be it.

cloudbees-pull-request-builder commented 9 years ago

asgard-pull-requests #496 FAILURE Looks like there's a problem with this pull request

csm commented 9 years ago

OK, now I have no clue what your builtbot is complaining about. The test results show zero failures, and zero codenarc issues. What's the deal?

claymccoy commented 9 years ago

Looks like a compilation error:

Compilation error: startup failed: /scratch/jenkins/workspace/asgard-pull-requests/grails-app/controllers/com/netflix/asgard/ImageController.groovy: 433: unexpected token: = @ line 433, column 17.

command.grailsApplication.config.promote?.targetServerRootUrls ?: [] ^

On Tue, May 12, 2015 at 1:35 PM, Casey Marshall notifications@github.com wrote:

OK, now I have no clue what your builtbot is complaining about. The test results show zero failures, and zero codenarc issues. What's the deal?

— Reply to this email directly or view it on GitHub https://github.com/Netflix/asgard/pull/670#issuecomment-101412384.

cloudbees-pull-request-builder commented 9 years ago

asgard-pull-requests #497 SUCCESS This pull request looks good

csm commented 9 years ago

Indeed, that wasn't quite the way to split a long line in Groovy.