Netflix / astyanax

Cassandra Java Client
Apache License 2.0
1.04k stars 355 forks source link

Update commons-csv dependency #582

Open bardhi opened 9 years ago

bardhi commented 9 years ago

astyanax-cassandra currently has a dependency on an old servicemix version of commons-csv. In astyanax-cassandra/build.gradle:

compile "org.apache.servicemix.bundles:org.apache.servicemix.bundles.commons-csv:$commonsCsvVersion"

The version is specified in dependency-versions.gradle:

commonsCsvVersion = "1.0-r706900_3"

I believe this library is only being used in CsvColumnReader and CsvRecordReader -- search results for "CSVParser" here. The servicemix version is pretty old, as it contains methods like getLine(), which are no longer available in commons-csv (javadoc here).

Also, it looks like ultimately the CSV parsing is only used in ThriftKeyspaceImplTest.java, in the astyanax-test project. I think it would be good to 1) move the gradle dependency as well as CsvColumnReader and CsvRecordReader into astyanax-test and 2) potentially update the gradle dependency (and corresponding code usage) to the latest, i.e. org.apache.commons:commons-csv:1.1. This might not be easily doable if astyanax-test needs to be osgi-compatible.

Does this sound reasonable? If so, I'm happy to make the change and submit a PR if that works.