Netflix / astyanax

Cassandra Java Client
Apache License 2.0
1.04k stars 354 forks source link

Error while Shutting down tomcat while using astyanax library #616

Open harrydevnull opened 8 years ago

harrydevnull commented 8 years ago

I use astyanax cassandra driver on tomcat to access data from cassandra. while stopping tomcat server; it is hung on threads started from astyanax library. Has any one come across this issue? this seems to create memory leaks for my application is there any resolution for this?

appears to have started a thread named [SMA_ScoreReset] but has failed to stop it. This is very likely to create a memory leak
appears to have started a thread named [pool-9-thread-1] but has failed to stop it. This is very likely to create a memory leak
appears to have started a thread named [pool-7-thread-35] but has failed to stop it. This is very likely to create a memory leak

I do have code which is to supposed to bring down the connection on shutdown

    @PreDestroy
    public void cleanup() {
        if(!this.shutdownPerformed.booleanValue() && this.contextMap != null && !this.contextMap.isEmpty()) {
            this.shutdownPerformed = Boolean.valueOf(true);
            logger.info("Shutdown context for " + this.contextMap.keySet());
            Iterator i$ = this.contextMap.keySet().iterator();

            while(i$.hasNext()) {
                String ksName = (String)i$.next();
                AstyanaxContext context = (AstyanaxContext)this.contextMap.get(ksName);
                if(context != null) {
                    logger.info("shutdown context for keyspace " + ksName);
                    ExecutorService asyncExecutor = context.getAstyanaxConfiguration().getAsyncExecutor();
                    asyncExecutor.shutdown();

                    try {
                        asyncExecutor.awaitTermination(10000L, TIMEUNIT.MILLISECONDS);
                    } catch (InterruptedException var6) {
                        ;
                    }

                    context.shutdown();
                }
            }
        }

    }