search

Netflix / conductor-community

Apache License 2.0
61 stars 72 forks source link

feature: Not storing duplicate data in external storage #153

Closed SimonMisencik closed 1 year ago

SimonMisencik commented 1 year ago

Signed-off-by: Simon Misencik simon.misencik@gmail.com

Pull Request type

Changes in this PR

Discussion: https://github.com/Netflix/conductor/discussions/3384

This PR implements calculating digest(sha-256) from payloadBytes. This digest is used as an id for record in the database. However, if the same digest/id is already in the database, it only updates the create_at data to prevent deletion during the cleaning of old data.

Alternatives considered

Describe alternative implementation you have considered

SimonMisencik commented 1 year ago

Build failed because of dependency on this PR: https://github.com/Netflix/conductor/pull/3383

github-actions[bot] commented 1 year ago

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days.

SimonMisencik commented 1 year ago

https://github.com/Netflix/conductor/pull/3383 was merged. Please rerun the build.

marosmars commented 1 year ago

Hey @apanicker-nflx , could we get a retrigger here ? and then a review.

Thank you, Maros