Netflix / conductor-community

Apache License 2.0
61 stars 72 forks source link

Adding Oracle Persistence DAO Layer #178

Closed conductor-community closed 1 year ago

conductor-community commented 1 year ago

Pull Request type

Changes in this PR

Oracle DAO Layer

Describe the new behavior from this PR, and why it's needed

Oracle Persistence / Option to use Oracle Database as persistence unit.

Alternatives considered

N/A

Technical Note

  1. Utilizes Oracle Database version 11G for Unit Tests

Due to GuitHub GI Container disk space limitation, no version > 11G can be used for Unit Tests. Can be easily upgraded to 18 XE or 19C Enterprise once GitHub Action updates size capacity which they are apparantly working on).

  1. Due to a technical version dependency, spring.flyway.locations cannot be automatically set to db/migration_oracle (similar to postgres-persistence) and has to be set through .properties file while running the jar along with conductor.db.type
  2. Flyway 6.4.4 (5.2+) - Only compatible with Oracle 12.2+
  3. Flyway 4.0.3 (<5.2) - Used for Unit Tests as Oracle 11G XE is used for Oracle Container.
bjpirt commented 1 year ago

I think this just needs a rebase as the failures have been fixed in Main now

github-actions[bot] commented 1 year ago

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This PR was closed, because it has been stalled for 7 days with no activity.