search

Netflix / conductor-community

Apache License 2.0
61 stars 72 forks source link

Feature: Webhooks for workflow and task status #228

Open charybr opened 1 year ago

charybr commented 1 year ago

Pull Request type

Changes in this PR

Describe the new behavior from this PR, and why it's needed Issue #212

Webhooks for workflow and task status

Problem: We have a requirement to publish status of workflow and task to a Webhook.

Approach: WorkflowStatusListener and TaskStatusListener interfaces can be implemented to call webhooks when there is a change in status of workflow and task. We can add new module called 'webhook'.

This PR is originated from the changes done by @techyragu (Rahul Gupta) done on CiscoM31/conductor https://github.com/CiscoM31/conductor/pull/26.

Alternatives considered

Describe alternative implementation you have considered

charybr commented 1 year ago

Hi @youngledo , your changes were in branch charybr:feature/webhook. I cherry-picked your commits into branch of this PR i.e. charybr:feature/task_webhook.

So please review below commits: https://github.com/Netflix/conductor-community/pull/228/commits/20a609da9ab6b343000567599331f1ebeba5465a https://github.com/Netflix/conductor-community/pull/228/commits/42c7ae255c94126fc67ea35d0153eb34ff275b7d

youngledo commented 1 year ago

Hi @youngledo , your changes were in branch charybr:feature/webhook. I cherry-picked your commits into branch of this PR i.e. charybr:feature/task_webhook.

So please review below commits: 20a609d 42c7ae2

OK, I've already reviewed it.

manan164 commented 1 year ago

Hi @charybr , Please make the below changes,

  1. Remove usage of webhook as it is conflicting with system task webhooks in workflow
  2. Make workflow publisher part of workflow-status-event-listerner module
  3. Add new module task-status-listener and move task status related changes there.
github-actions[bot] commented 1 year ago

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days.

charybr commented 1 year ago

Commenting so that Stale label gets removed. Will work on the review comments in Dec.