Issue#241 fix AMQPObservableQueue behaviour to return failed message…

Netflix / conductor-community

Apache License 2.0

61 stars 72 forks source link

Issue#241 fix AMQPObservableQueue behaviour to return failed message… #242

Closed jcockrill-rq closed 1 year ago

jcockrill-rq commented 1 year ago

Pull Request type

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
[ ] WHOSUSING.md
[ ] Other (please describe):

Changes in this PR

Fixed AMQPObservableQueue#ack to correctly implement its interface definition, but returning the unsuccessfully-ack'ed messages and not the successfully ack'ed ones.

Issue #241

Alternatives considered

None

github-actions[bot] commented 1 year ago

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days.

jcockrill-rq commented 1 year ago

@v1r3n - could you check and approve this PR please? Currently AMQPObservableQueue is logging a ton of errors when it shouldn't be. This PR has been marked as stale and I cann't remove it.