search

Netflix / conductor-community

Apache License 2.0
61 stars 71 forks source link

Unable to override postgres schema_name as "conductor" in conductor 3.7.3 #99

Open trivedishalini opened 2 years ago

trivedishalini commented 2 years ago

Describe the bug I am trying to upgrade conductor 3.7.3 version but after upgrade conductor server not starting because in this version schema as "public" is hardcoded in PostgresConfiguration which not allowing to override any other schema name like "conductor" etc. For my project need ,I have use only different schema name thats why this issue need to fix so that I can override db schema.

Suggested Fix I spend some time on this conductor repo to fixed the issue so that anyone can override conductor schema property but I am unable to raise PR against tag v3.7.3 so that this fix can review and merge. Fixed present in below fork . https://github.com/Netflix/conductor/compare/main...trivedishalini:conductor-v3.7.3

Please take a look and suggest further as I have project release coming up in next 2 weeks .

Note Fix needed in v3.7.3 conductor tag

Details Conductor-Server version: 3.7.3 Persistence implementation: Postgress Queue implementation: Postgres Postgres_schema_name: conductor Postgres_database_name: conductor Postgres_database_user: conductor Lock: Redis Workflow definition: N/A Task definition: N/A Event handler definition: N/A

Below Screenshots for conductor PostgresConfiguration class which have schema hardcoded as public

image
boney9 commented 2 years ago

On the main branch the postgres persistence module has moved here: https://github.com/Netflix/conductor-community/tree/main/persistence/postgres-persistence

You can submit your PR to that repo and we should be able to add this in.

trivedishalini commented 2 years ago

@boney9 , I need this fix on v3.7.3 tag which need to fix in this conductor repo .this version I need for my project release. Can you please help me to provide fix on tag v3.7.3.

Later on I will raise PR on community project too .

trivedishalini commented 2 years ago

I got this working in below 3.7.3 patch release . thanks for merging pr

io.orkes.conductor conductor-server 3.7.3-a pom
shekarpcs commented 1 year ago

All,

Could you please merge this to community schema. It is impacting our production and we are not able to upgrade condcutor from 3.4 to 3.11. We are worried.

could you please merge this to community version to latest