Fix: #3876 Update task utils: removeIterationFromTaskRefName

[appunni-old]

Parsing name is not considering task ref name with double underscores

• This is not fully fixing the use of this function. There needs to be some kind of validation against the user from setting up the taskRefName with double underscore

Pull Request type

• [x] Bugfix
• [ ] Feature
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
• [ ] WHOSUSING.md
• [ ] Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed Issue #3876 If taskRefName with double underscore is not considered, then task creation would go into infinite loop. This can be used also as an attack vector on conductor installation as this causes DDos

Alternatives considered

Add validation in the create start workflow / create workflow definition api

Describe alternative implementation you have considered

[v1r3n]

Hi @appunni-m can you fix the build?

[appunni-old]

@v1r3n hey I have fixed the build.

[appunni-old]

I am making one more change @v1r3n this will solve for #3880 as well

[manan164]

Hi @appunni-m , Is there a particular reason that you are using double underscore in the task reference name?

[appunni-old]

@manan164 i take it as input from user, thus I don't want to take chances with it. There are no validations against it either.

[appunni-old]

@manan164 can we merge this ? Any blocker ?