search

Netflix / denominator

Portably control DNS clouds using java or bash
Apache License 2.0
580 stars 110 forks source link

build no longer creates cli/build/denominator #272

Closed codefromthecrypt closed 9 years ago

codefromthecrypt commented 9 years ago

Before switching to the latest nebula, executing ./gradlew clean test install from the root of your denominator clone would create cli/build/denominator

This was due to an entry at the bottom of the cli's build.gradle

artifacts {
  archives fatJar
}

I noticed this is no longer being created. Any ideas?

rspieldenner commented 9 years ago

Does it absolutely have to be an executable jar? I'd usually go with the 'application' plugin to do this type of thing http://gradle.org/docs/current/userguide/application_plugin.html

Otherwise I'll take a look Monday.

codefromthecrypt commented 9 years ago

there's a fair amount of denominator cli users who see it as an executable. I can also look into the gradles if you get stuck.. just I'm usually not that good at it.

rspieldenner commented 9 years ago

When I do ./gradlew clean build install I get a cli/build/denominator. I'm doing this on the master branch.

codefromthecrypt commented 9 years ago

oh well that's interesting! maybe there's a subtle thing when one puts "test" instead of "build" now. I don't mind the incantation so long as the release scripts create this..

codefromthecrypt commented 9 years ago

No action needed.. I'll just update the README!

rspieldenner commented 9 years ago

actually thought about it some more. And pull request does it the old way.

codefromthecrypt commented 9 years ago

Great. This helps, Rob.