Issue 280: Map Credentials does not work some times

[santhosh-tekuri]

provider should handle each credential type separately

[cloudbees-pull-request-builder]

denominator-pull-requests #395 FAILURE Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

NetflixOSS » denominator » denominator-pull-requests #20 FAILURE Looks like there's a problem with this pull request

[santhosh-tekuri]

fixed the failure

[cloudbees-pull-request-builder]

denominator-pull-requests #397 SUCCESS This pull request looks good

[cloudbees-pull-request-builder]

NetflixOSS » denominator » denominator-pull-requests #22 SUCCESS This pull request looks good

[codefromthecrypt]

A couple nits, but the code looks like the cure!

Please add the following to the changelog:

• Allows map credentials to be used without regard to iteration order

Please also squash and reword your commit.

In feign and denominator, I'm trying to stop the behavior I started w/ not so hot commit messages. when this is complete, please squash your commits into one where the first line says what the commit does, and later references other issues. Ex.

Here's a nice commit message for the work you've done.

Allows map credentials to be used without regard to iteration order

ListCredentials.asList only works when an input map iterates in the same
order as Provider.credentialTypeToParameterNames(). This is a bad
assumption and the method is now deprecated.

closes #280

Note all lines wrap at 72 chars and summary doesn't wrap, nor has a period. Note that we use closes # syntax to reference the issue, but not on the summary.

[cloudbees-pull-request-builder]

NetflixOSS » denominator » denominator-pull-requests #25 SUCCESS This pull request looks good

[cloudbees-pull-request-builder]

denominator-pull-requests #400 SUCCESS This pull request looks good

[codefromthecrypt]

LG I will update the CHANGELOG in a cherry-pick

[codefromthecrypt]

Thanks!

closed via e6dfb6c175385af900d3a4a012e342ab8030dc71