search

Netflix / denominator

Portably control DNS clouds using java or bash
Apache License 2.0
580 stars 110 forks source link

Dynect Provider does not returns type-safe rdata #297

Closed santhosh-tekuri closed 9 years ago

santhosh-tekuri commented 9 years ago

in Dynect Provider, the ResourceRecordSet returned by api, always contains records of type LinkedHashMap. It should contain records of type-safe subclasses like AData, AAAAData etc. All other providers return type-safe rdata.

closes #296

cloudbees-pull-request-builder commented 9 years ago

denominator-pull-requests #403 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 9 years ago

NetflixOSS » denominator » denominator-pull-requests #28 SUCCESS This pull request looks good

codefromthecrypt commented 9 years ago

Looks good, but I would guess you would want a test case, right? I don't recall if dynect has an existing test class for rdata conversions, but I know some providers do.

Ps when you are raising both the issue and the solution, just open a PR (no tracking issue needed).

santhosh-tekuri commented 9 years ago

I did not find any test cases for rdata conversions in other providers. could you point to any, if you know.

in case if i open just PR: then i dont need to add "closes #xxx" in comment. am i right?

codefromthecrypt commented 9 years ago

I did not find any test cases for rdata conversions in other providers. could you point to any, if you know.

Here's an example:

https://github.com/Netflix/denominator/blob/master/ultradns/src/test/java/denominator/ultradns/UltraDNSFunctionsTest.java

in case if i open just PR: then i dont need to add "closes #xxx" in comment. am i right?

Yep!

cloudbees-pull-request-builder commented 9 years ago

denominator-pull-requests #404 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 9 years ago

NetflixOSS » denominator » denominator-pull-requests #29 SUCCESS This pull request looks good

santhosh-tekuri commented 9 years ago

i am using Idea, and it puts them;

also i manually changed from 4space indentation to 2space etc....

cloudbees-pull-request-builder commented 9 years ago

denominator-pull-requests #405 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 9 years ago

NetflixOSS » denominator » denominator-pull-requests #30 SUCCESS This pull request looks good

codefromthecrypt commented 9 years ago

If you use this, it should correct the import rules.

http://code.google.com/p/google-styleguide/source/browse/trunk/intellij-java-google-style.xml

cloudbees-pull-request-builder commented 9 years ago

NetflixOSS » denominator » denominator-pull-requests #31 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 9 years ago

denominator-pull-requests #406 ABORTED

codefromthecrypt commented 9 years ago

looks great, Santosh! just reword the commit and add to changelog:

Changes DynECT to return type-safe rdata

cloudbees-pull-request-builder commented 9 years ago

denominator-pull-requests #407 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 9 years ago

NetflixOSS » denominator » denominator-pull-requests #32 SUCCESS This pull request looks good