search

Netflix / denominator

Portably control DNS clouds using java or bash
Apache License 2.0
580 stars 110 forks source link

Removes Pems code from DiscoveryDNS and runs tests using https #309

Closed codefromthecrypt closed 9 years ago

codefromthecrypt commented 9 years ago

This changes the discoverydns credentials to accept what's actually needed. java.security.cert.X509Certificate and java.security.PrivateKey

The Credentials concept in denominator intentionally allows values to be objects. This is so that it doesn't have an opinion on how credentials which take forms besides string are supplied.

We don't want to get into the business of maintaining Pem reading code if we can avoid it. This frees users to use bouncycastle or anything else to construct the certificate and private key.

For the purposes of tests and the CLI, we'd probably still need to accept Pem format, just not in the base provider.

closes #308

cloudbees-pull-request-builder commented 9 years ago

denominator-pull-requests #420 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 9 years ago

NetflixOSS » denominator » denominator-pull-requests #45 SUCCESS This pull request looks good