Closed codefromthecrypt closed 9 years ago
denominator-pull-requests #423 SUCCESS This pull request looks good
NetflixOSS » denominator » denominator-pull-requests #48 SUCCESS This pull request looks good
@wnagele sorry to have to do this, but these record types have absorbed quite a bit of effort. I had to roll them back. I shouldn't have merged the PR earlier without testing it.
I know there's a pretty robust version of LOC in hopper (cc @jdamick @jonbodner). Hopefully, we can get LOC back again soon.
I've serious doubts about adding DNSSEC types. The more code we put into denominator, the more easily we can swamp it. We have to choose very carefully.
denominator-pull-requests #424 SUCCESS This pull request looks good
NetflixOSS » denominator » denominator-pull-requests #49 SUCCESS This pull request looks good
A couple DNSSec (TLSA, DS) record types were recently added, but not tested. Live tests started to fail on these, and since DNSSec is not something Denominator aims to address, they should be removed.
The LOC record type is desirable, but the implementation isn't ready to be relied on. This should be reintroduced later, possibly based on hopper, and cross-checked with DynECT to ensure it actually works. In the mean time, this removes the LOC record type.
Finally, the CERT record type needed some adjustments before it could pass tests. These adjustments work on DynECT (so far).
See https://github.com/ultradns/hopper/blob/master/src/main/java/biz/neustar/hopper/record/LOCRecord.java See https://help.dyn.com/create-loc-record-api See #256