Closed dwilkolek closed 3 months ago
Sure, I'll take a stab at it shortly.
While peeking at java code path I've found a bug in kotlin path. When using typeMapping with Person to DifferentlyNamedClass
mapping then it would fail.
Regarding Java path it will be slightly more difficult. In Kotlin path I used named parameters. In Java I see 4 paths:
ObjectMapper
to create object in placeI've implemented option 2. Lmk what do you think 🙏
I realised that kotlin2 did not support default values at all. Now experience with default values should be the same across codegen configurations.
@mbossenbroek This PR contains kotlin2 changes - added support for default values in input types 😉 @srinivasankavitha I've implemented java code path using initialiser block
If it make sense to you I can split changes into 2 PRs; one for object defaults, one adding kotlin2 default values
Looks good to me! 👍 I'll let @srinivasankavitha merge it cause there are other changes in there too
@srinivasankavitha Are you waiting for any action from my side or is it ready to go? I'm not a huge fan of stale PRs hanging out in void 😅
Sorry for the delay, and thanks for bringing this back to my attention. Just merged the PR and will go out in next week's release.
closes #297