search

Netflix / dgs-framework

GraphQL for Java with Spring Boot made easy.
https://netflix.github.io/dgs
Apache License 2.0
3.07k stars 295 forks source link

feature: Support SSE on Webflux #1448

Closed esfomeado closed 1 month ago

esfomeado commented 1 year ago

Please read our contributor guide before creating an issue. Also consider discussing your idea on the discussion forum first.

Describe the Feature Request

As of now only WebSockets are supported on Webflux.

It would be helpful if SSE were supported as well.

Describe Preferred Solution

Similar to how it happens now for MVC.

If the SSE module is included wire up the SSE handler.

srinivasankavitha commented 1 year ago

Thanks for creating an issue. We won't be able to prioritize this anytime soon since webflux stack is not use internally yet. We do welcome PR contributions if anyone is interested.

On Thu, Mar 2, 2023 at 11:03 AM esfomeado @.***> wrote:

Please read our contributor guide https://github.com/Netflix/dgs-framework/blob/master/CONTRIBUTING.md before creating an issue. Also consider discussing your idea on the discussion forum https://github.com/Netflix/dgs-framework/discussions first. Describe the Feature Request

As of now only WebSockets are supported on Webflux.

It would be helpful if SSE were supported as well. Describe Preferred Solution

Similar to how it happens now for MVC.

If the SSE module is included wire up the SSE handler.

— Reply to this email directly, view it on GitHub https://github.com/Netflix/dgs-framework/issues/1448, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5JPXLVLYSWE35L53C523TW2DVJVANCNFSM6AAAAAAVNYJPGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

paulbakker commented 1 month ago

WebFlux support now comes from Spring GraphQL, so this would have to be implemented there. Closing this issue as not actionable.