search

Netflix / dgs-framework

GraphQL for Java with Spring Boot made easy.
https://netflix.github.io/dgs
Apache License 2.0
3.03k stars 286 forks source link

Make all timer threads daemonic in subscription handlers #1811

Closed kilink closed 5 months ago

kilink commented 5 months ago

Make sure all the Timer instances use daemonic threads so they don't block JVM shutdown, and add a PreDestroy method to the implementations to proactively clean up the session watchdog Timer. Additionally, add a descriptive name to each Timer instance.

srinivasankavitha commented 5 months ago

Should we uncomment the subscription tests as well to see if this fixes the hanging tests?

kilink commented 5 months ago

Should we uncomment the subscription tests as well to see if this fixes the hanging tests?

Actually, the only disabled tests I can find are from graphql-dgs-subscriptions-sse, which I didn't touch in this PR.