search

Netflix / dgs-framework

GraphQL for Java with Spring Boot made easy.
https://netflix.github.io/dgs
Apache License 2.0
3.06k stars 295 forks source link

Increment error metric #1816

Closed spellew closed 7 months ago

spellew commented 7 months ago

Recent PR accidentally removed the increment call from the gql.error metric. Fixed bug and improved tests to ensure metric count is incremented.

rhino88 commented 7 months ago

@kilink are we able to cut a new release with this change? This issue is impacting observability for us in production.

deweyjose commented 7 months ago

This is impacting our teams in production as well. Any timelines on release?

evanmalmud commented 7 months ago

Same here! I want to fix our metrics!

Emily commented 7 months ago

@deweyjose @evanmalmud v8.3.1 is releasing right now!

deweyjose commented 7 months ago

Thank you @Emily !