Netflix / dgs-framework

GraphQL for Java with Spring Boot made easy.
https://netflix.github.io/dgs
Apache License 2.0
3.06k stars 295 forks source link

add new hooks for instrumenting dataloaders #1818

Closed Emily closed 7 months ago

Emily commented 7 months ago

Pull request checklist

Pull Request type

Changes in this PR

add new hooks for instrumenting dataloaders

also note: it is likely that in the future this will be able to simplify the current micrometer metrics instrumentation that uses ByteBuddy.

paulbakker commented 7 months ago

I'm curious if you've tried to replace the bytebuddy stuff with this. At the very least it would be a good way to test the new API, see if it's possible or what you run into.

I generally like the approach with the two different interfaces that happen at different times in the lifecycle.

Emily commented 7 months ago

@kilink @srinivasankavitha @paulbakker PTAL

@paulbakker I haven't yet, as the tests for the data loader metrics are currently disabled. Re-enabling them looks to be moderately involved so I was going to do that and the new style of instrumentation together as a follow up.