bug: Switching to `graphql-dgs-spring-graphql-starter` breaks `Upload` GraphQL scalar

vigenere23 commented 5 months ago

Expected behavior

Should work like before, as described by the documentation.

Actual behavior

Since switching from graphql-dgs-spring-boot-starter to graphql-dgs-spring-graphql-starter, we now have a runtime error at the start of our application, stating There is no scalar implementation for the named 'Upload' scalar type. We have followed the documentation and it was working before the switch.

Steps to reproduce

Following this doc : https://netflix.github.io/dgs/advanced/file-uploads/
Using codegen, we also added Upload: "org.springframework.web.multipart.MultipartFile" to the typeMapping plugin configuration
In our data-fetcher, we receive a MultipartFile as input, which does compile

We are using Gradle with Kotlin and are on the latest version of both dgs codegen (6.1.6), dgs framework (8.5.6) and spring-boot (3.2.4). Here are all the dgs libraries that we are using :

implementation("com.netflix.graphql.dgs:graphql-dgs-spring-graphql-starter")
implementation("com.netflix.graphql.dgs:graphql-dgs-extended-scalars")
implementation("com.netflix.graphql.dgs:graphql-dgs-spring-boot-micrometer")
implementation("com.netflix.graphql.dgs:graphql-dgs-pagination")

We are also using the spring-boot-starter-web library.

srinivasankavitha commented 5 months ago

WIth spring-graphql, you now need to add an external dependency for file uploads: https://netflix.github.io/dgs/spring-graphql-integration/#file-uploads

vigenere23 commented 5 months ago

Wow thanks for the quick response! Should that section also be part of the "File Uploads" specific documentation page? Or at least a link that refers the page you mentioned?

srinivasankavitha commented 5 months ago

Yes, that's a good idea. I will fix that.

On Fri, Apr 19, 2024 at 1:41 PM Gab S. @.***> wrote:

Wow thanks for the quick response! Should that section also be part of the "File Uploads" specific documentation page? Or at least a link that refers the page you mentioned?

— Reply to this email directly, view it on GitHub https://github.com/Netflix/dgs-framework/issues/1889#issuecomment-2067256649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5JPXNPUYYG4RPKN34EPDTY6F6NXAVCNFSM6AAAAABGPZIU7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGI2TMNRUHE . You are receiving this because you commented.Message ID: @.***>

Netflix / dgs-framework