search

Netflix / dgs-framework

GraphQL for Java with Spring Boot made easy.
https://netflix.github.io/dgs
Apache License 2.0
3.1k stars 297 forks source link

bug: Cannot implement Kotlin interface DgsReactiveCustomContextBuilderWithRequest in Java #2023

Closed petrmac closed 2 weeks ago

petrmac commented 2 months ago

Please read our contributor guide before creating an issue.

Expected behavior

Interface should be possible to implement

Actual behavior

When trying to implement the interface in Java project, the interface is not visible:

error: cannot find symbol
public class CredentialsContextBuilder implements DgsReactiveCustomContextBuilderWithRequest<CredentialsContext> {
                                                  ^
  symbol: class DgsReactiveCustomContextBuilderWithRequest

Steps to reproduce

Implement the interface in Java project (not Kotlin). Using the version: graphql-dgs-reactive-9.1.0.jar

Initially was using: implementation "com.netflix.graphql.dgs:graphql-dgs-webflux-starter" but now migrated to the newly endorsed
implementation "com.netflix.graphql.dgs:graphql-dgs-spring-graphql-starter"

Any help would be greatly appreciated!

awesor commented 2 weeks ago

This was an awesome fix! Thank you so much for getting on this, @asibross so quickly.

Out of curiosity, since we're really eager on my end to use this, when are we looking at cutting a new release (or rc) that would contain this fix?

paulbakker commented 2 weeks ago

Released in 9.2.0.