berngp
commented
2 years ago Thanks for reporting the issue @shiyouping.
Closed shiyouping closed 10 months ago
berngp
commented
2 years ago Thanks for reporting the issue @shiyouping.
srinivasankavitha
commented
2 years ago Thanks, we do not support File uploads with webflux yet.
On Mon, Jan 17, 2022 at 12:11 PM Bernardo Gomez Palacio < @.***> wrote:
Thanks for reporting the issue @shiyouping https://github.com/shiyouping .
— Reply to this email directly, view it on GitHub https://github.com/Netflix/dgs-framework/issues/819#issuecomment-1014856346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5JPXLEEMMBET5AMWYPBDDUWRZXRANCNFSM5LTYPEUA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
shiyouping
commented
2 years ago Any schedule to support it? Thanks in advance. @srinivasankavitha @berngp
srinivasankavitha
commented
2 years ago We do not plan on adding support in the next few months at least, since WebFlux is not used internally. You are also the first to request this feature. We do welcome contributions from folks willing to help out with this.
On Fri, Jan 21, 2022 at 12:23 AM Shi Youping @.***> wrote:
Any schedule to support it? Thanks in advance.
— Reply to this email directly, view it on GitHub https://github.com/Netflix/dgs-framework/issues/819#issuecomment-1018284109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5JPXMT34YNS74RYUHZKOTUXEJZDANCNFSM5LTYPEUA . You are receiving this because you commented.Message ID: @.***>
ghost
commented
2 years ago I am having the same issue Would be great if this is supported in the future Thanks
ghost
commented
2 years ago Is there any way of doing a temporal fix or some hack in order to still use webflux but just use spring web mvc in the file uploads or I must have all the project with spring mvc? Because right now I am forced to use Base64 as inputs in my file uploads and this is not really well performant.
shiyouping
commented
2 years ago @zanonena You can still use Spring Webflux to upload the files without dgs-framework. Here is a sample code https://github.com/shiyouping/hohomalls/blob/master/server/hohomalls-web/src/main/java/com/hohomalls/web/controller/FileController.java
ghost
commented
2 years ago @zanonena You can still use Spring Webflux to upload the files without dgs-framework. Here is a sample code https://github.com/shiyouping/hohomalls/blob/master/server/hohomalls-web/src/main/java/com/hohomalls/web/controller/FileController.java
Thanks! but I must use GraphQL
bartebor
commented
1 year ago I must admit that DGS library is well designed and I have never had any problems using it in WebFlux mode. That is, until I had to implement file uploads. The lack of file uploads in WebFlux is not documented, so I was very disappointed when I found this issue open.
I need file uploads, so I came up with workaround. This is essentially custom HTTP handler bean with few classes operating on Part class instead of MultipartFile. I'm not familiar with Kotlin unfortunately, so I can't make a PR at the moment. For those who may find it handy I'm leaving a link to my Java hack.
It would be great if maintainers implemented file uploads in WebFlux flavor!
Pretty, pretty please with sugar on top :wink:
srinivasankavitha
commented
1 year ago @bartebor - Thanks for posting your solution for the workaround. Unfortunately, this feature is unlikely to be prioritized anytime soon due to internal conflicting requests. We do not use Webflux within Netflix yet. We are open to contributions though, so if anyone if interested, we would welcome the support!
hwhh
commented
10 months ago Any chance this will be added soon or has been added?
srinivasankavitha
commented
10 months ago Unfortunately this is not a priority for us since we do not use the webflux stack internally, and therefore unlikely we will support this in the future for webflux. We'll update our documentation to reflect this.
On Wed, Nov 8, 2023 at 6:29 PM hwhh @.***> wrote:
Any chance this will be added soon or has been added?
— Reply to this email directly, view it on GitHub https://github.com/Netflix/dgs-framework/issues/819#issuecomment-1803066427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5JPXLYDA7USO32EF56ZELYDQ5YPAVCNFSM5LTYPEUKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBQGMYDMNRUGI3Q . You are receiving this because you were mentioned.Message ID: @.***>
lthoulon-locala
commented
8 months ago Hello.
Let me first say that I really like the DGS framework. It's great to work with. However I'm disappointed to find out that you're not considering handling this. This seems like a must have for anyone who wants to use DGS and works with webflux (which is probably an increasing number of users).
☝🏼In any case it would be great if you could add this limitation to the file upload documentation because it's not obvious where the issue comes from at first and it's only once I included "multipart" in my search terms that I found this issue.
Although I do understand why Netflix chooses not to do this, I'm wondering about what this would actually cost from its point of view considering @bartebor seems to have provided some code that would serve as a base for this and that the dev teams working on this are probably used to the code and can do that in a timely fashion. Is the cost that great ? It feels that it would be of great value for the community at least. Considering you would still have to take the time to review the code of any new contributor and that this new contributor would have to go through the process of understanding how the DGS code works, isn't there any amount of value in doing this ?
If I knew where to start I might actually be that contributor but I'm not sure what I would be getting into and I can't afford that right now. Maybe in a couple weeks once I've set up a workaround and delivered a first version of my project. But we all know how that generally goes.
I won't hide it, I hope you change you mind on the subject. 😁
Thanks again for all the work you're doing. It's much appreciated. 🫶🏼
paulbakker
commented
8 months ago As a side effect of some bigger news coming soon, this will actually be supported soon.
lthoulon-locala
commented
8 months ago Awesome. Meanwhile if anyone is looking for a Kotlin version of the hack initially provided by @bartebor You'll find it here: https://gist.github.com/lthoulon-locala/02efaf339d9f6b8795bc48f425926efe
I reworked this based on the original Netflix files so that the code is as close as possible to theirs.
lthoulon-locala
commented
1 week ago If anyone is looking up how to update the code with the latest integration with spring-graphql (dgs 9.1.0) it now almost out of the box as explained here: https://netflix.github.io/dgs/spring-graphql-integration/#file-uploads
You need to use this dependency:
<dependency>
<groupId>name.nkonev.multipart-spring-graphql</groupId>
<artifactId>multipart-spring-graphql</artifactId>
<version>${multipart-spring-graphql.version}</version>
</dependency>Then you can do the following
@DgsMutation
fun myMutationWithAFileUpload(@InputArgument myFile: FilePart) =
myFile.content().let { mergeDataBuffers(it) }.flatMap { doSomethingWithThatFile(it) }
companion object {
fun mergeDataBuffers(dataBufferFlux: Flux<DataBuffer>): Mono<ByteArray> =
DataBufferUtils.join(dataBufferFlux).map { dataBuffer ->
val bytes = ByteArray(dataBuffer.readableByteCount())
dataBuffer.read(bytes)
DataBufferUtils.release(dataBuffer)
bytes
}
}You can remove all the rest of the specific code provided in the previous comments. And that's it!
Expected behavior
According to DGS document and GraphQL multipart request specification, file upload should work as expected.
Actual behavior
com.netflix.graphql.dgs.webflux.handlers.DefaultDgsWebfluxHttpHandlerwill treat form-data requests asapplication/jsonand usecom.fasterxml.jackson.databind.ObjectMapperto parse the requests. Then the framework will throw the following exception:Steps to reproduce
I have used cURL, Postman and Altair GraphQL Client to test the file upload without luck.
type Mutation {
Upload a file and return the URL on the server
}
Use cURL to upload the file:
Error responses in cURL, Postman and Altair GraphQL Client: