search

Netflix / dispatch-docker

Apache License 2.0
206 stars 87 forks source link

Allow build time variables VUE_APP_* #116

Closed ymatsiuk closed 3 years ago

ymatsiuk commented 3 years ago

There is an issue when using latest release all VUE_APP_* variables coming from .env ignored. To make this work we checkout dispatch, set context to ../dispatch and add these variables to ../dispatch/src/dispatch/static/dispatch/.env

To reproduce:

  1. create .env file
  2. add VUE_APP_DISPATCH_AUTHENTICATION_PROVIDER_SLUG=dispatch-auth-provider-pkce
  3. run ./install.sh
  4. debug in browser show undefined for VUE_APP_DISPATCH_AUTHENTICATION_PROVIDER_SLUG value and dispatch falls back to basic auth 🤷🏻‍♂️

This is because docker uses env file only during run process, not build process.

Additional change is required on Dockerfile side: https://github.com/Netflix/dispatch/pull/1533

ymatsiuk commented 3 years ago

@kevgliss 🙏

kevgliss commented 3 years ago

lgtm thanks!