search

Netflix / dispatch-docker

Apache License 2.0
206 stars 87 forks source link

Remove dependency to local postgres client tools #97

Closed fkrauthan closed 3 years ago

fkrauthan commented 3 years ago

I run into the same issue as #92 since I did not have postgres client tools installed. This merge request moves the postgres calls (to initialize the test data) to be run within the docker container. This way nothing but docker needs to be installed to run dispatch and to initialize test data.

mvilanova commented 3 years ago

Thanks again for the PR!

fkrauthan commented 3 years ago

No problem. Btw I did not use the FILE_NAME variable in the URL variable on purpose. The idea was that you could add the downloaded filename to .gitignore and if you ever have a sample v2 file you could just change the URL variable instead of ether having to modify the filename and gitignore or always having to save the seed file with the same name. But probably more a hypothetical scenario.

kevgliss commented 3 years ago

Nice! I had tried to do it inside the container initially, but couldn't find the right docker-compose incantation, glad you did!