search

Netflix / dispatch

All of the ad-hoc things you're doing to manage incidents today, done for you, and much more!
Apache License 2.0
4.95k stars 488 forks source link

bug: resource doesn't have property "name". conversation flows #5022

Closed vindex10 closed 1 week ago

vindex10 commented 1 month ago

Only Document has property "name". Rest log warnings crash the request:

https://github.com/Netflix/dispatch/blob/fc9e0287e4c34fee34257cd6c8685a8c043a5887/src/dispatch/conversation/flows.py#L316

        log.warning(
            f"Conversation bookmark {resource.name.lower()} not added. No conversation available."
        )

the easiest fix could be to replace resource.name with resource.__class__.__name__

or add name to each of the class definitions: Resource = Document | Conference | Storage | Ticket

github-actions[bot] commented 2 weeks ago

This issue is stale, because it has been open for 30 days with no activity. Remove the stale label or comment, or this will be closed in 5 days.

github-actions[bot] commented 1 week ago

This issue was closed, because it has been stalled for 5 days with no activity.