Netflix / dyno

Java client for Dynomite
https://github.com/Netflix/dynomite
Apache License 2.0
186 stars 94 forks source link

Autoformatting code #269

Closed rsrinivasanNetflix closed 5 years ago

rsrinivasanNetflix commented 5 years ago

Autoformatting code. No functional code changes.

ipapapa commented 5 years ago

I am not sure what is the best way. Autoformat all files at once or autoformat only the files that are being changed in each PR. I understand that this will handle everything at once but then it may add overhead when studying the commit history. Just my 2 cents.

rsrinivasanNetflix commented 5 years ago

I am not sure what is the best way. Autoformat all files at once or autoformat only the files that are being changed in each PR. I understand that this will handle everything at once but then it may add overhead when studying the commit history. Just my 2 cents.

Good point. We could do it that way. I like not polluting the commit history. But when we are putting up a new PR it'll become difficult to review new changes. So, having it this way might be better for that?

rsrinivasanNetflix commented 5 years ago

Merging this as is since the other route of incremental formatting makes future PRs difficult to read.