Netflix / dynomite-manager

A sidecar to manage Dynomite clusters
https://github.com/Netflix/dynomite
Apache License 2.0
91 stars 59 forks source link

Unable to get dynomite-manager up and running #101

Closed suman-maity closed 6 years ago

suman-maity commented 6 years ago

I am trying to run dynomite manager on AWS but I am a bit confused on what values to set for the below env variables:

  1. NETFLIX_APP
  2. EC2_REGION
  3. NETFLIX_AUTO_SCALE_GROUP

These are picked up in the Java class: https://github.com/Netflix/dynomite-manager/blob/dev/dynomitemanager-common/src/main/java/com/netflix/nfsidecar/resources/env/InstanceEnvVariables.java

Also, are there any other environment variables or properties that need to be set/passed while starting dynomite manager?

shailesh33 commented 6 years ago

The NETFIX_APP is the application name that you are running this code in. EC2_REGION: is something like us-east-1 NETFLIX_AUTO_SCALE_GROUP: ASG that you run your app. Typically it is common to all the nodes in that ASG.

On Sun, Apr 29, 2018 at 7:47 PM, Suman Maity notifications@github.com wrote:

I am trying to run dynomite manager on AWS but I am a bit confused on what values to set for the below env variables:

  1. NETFLIX_APP
  2. EC2_REGION
  3. NETFLIX_AUTO_SCALE_GROUP

These are picked up in the Java class: https://github.com/Netflix/dynomite-manager/blob/dev/ dynomitemanager-common/src/main/java/com/netflix/nfsidecar/resources/env/ InstanceEnvVariables.java

Also, are there any other environment variables or properties that need to be set/passed while starting dynomite manager?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Netflix/dynomite-manager/issues/101, or mute the thread https://github.com/notifications/unsubscribe-auth/ALle53Upw0XVRH2uO6iz_B_9GgdgC8UOks5ttnsqgaJpZM4TsErS .

suman-maity commented 6 years ago

Hi Shailesh,

Thanks for the reply. Below is the method that reads the environment variable NETFIX_APP https://github.com/Netflix/dynomite-manager/blob/dev/dynomitemanager-common/src/main/java/com/netflix/nfsidecar/tokensdb/InstanceDataDAOCassandra.java

public String getDynomiteClusterName() { String clusterName = System.getenv("NETFLIX_APP"); /* if (StringUtils.isBlank(clusterName)) { logger.warn("Cluster name variable not defined. Falling back to FP " + config.getDynomiteClusterName()); clusterName = config.getDynomiteClusterName(); } */ return clusterName; }

The method's name is getDynomiteClusterName. What you said is that

The NETFIX_APP is the application name that you are running this code in.

So will this be "dynomite" or "dynomite-manager" or "dyn_o_mote"? The last one is the name of the dynomite cluster as configured in my dynomite.yaml file.

shailesh33 commented 6 years ago

Are you running it in AWS? then it is the app name of the Dynomite cluster. The one in the YAML file does not matter.

On Tue, May 1, 2018 at 10:35 PM, Suman Maity notifications@github.com wrote:

Hi Shailesh,

Thanks for the reply. Below is the method that reads the environment variable NETFIX_APP https://github.com/Netflix/dynomite-manager/blob/dev/ dynomitemanager-common/src/main/java/com/netflix/nfsidecar/tokensdb/ InstanceDataDAOCassandra.java http://url

public String getDynomiteClusterName() { String clusterName = System.getenv("NETFLIX_APP"); / if (StringUtils.isBlank(clusterName)) { logger.warn("Cluster name variable not defined. Falling back to FP " + config.getDynomiteClusterName()); clusterName = config.getDynomiteClusterName(); } / return clusterName; }

The method's name is getDynomiteClusterName. What you said is that

The NETFIX_APP is the application name that you are running this code in.

So will this be "dynomite" or "dynomite-manager" or "dyn_o_mote"? The last one is the name of the dynomite cluster as configured in my dynomite.yaml file.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Netflix/dynomite-manager/issues/101#issuecomment-385869459, or mute the thread https://github.com/notifications/unsubscribe-auth/ALle5zTQJuKEuQL_epZRbMFLOwVpRxzLks5tuUW3gaJpZM4TsErS .

ipapapa commented 6 years ago

I am closing this due to inactivity. However, I also want to note that IEnvVariables is an interface. You do not have to pick up the same variables as we use at Netflix. You can add your own implementation of the interface. It should be straightforward but if you have any questions please let us know.