search

Netflix / dynomite-manager

A sidecar to manage Dynomite clusters
https://github.com/Netflix/dynomite
Apache License 2.0
91 stars 59 forks source link

1. fix get region/dc bug 2. remove SimpleDB from default config sources #49

Closed akbarahmed closed 8 years ago

akbarahmed commented 8 years ago
  1. DynomitemanagerConfiguration had a bug where getRegion() (renamed to getDataCenter()) only checked the EC2_REGION env var.

The old getRegion() would return an empty region which would cause cascading failure.

I noticed the error when I got a null hostname exception by setting neither the EC2_REGION env var nor the value in a .properties file. However, EC2 metadata was returning the correct AZ, which was parsed to region, but was not used by getRegion()....thus the exception.

  1. simple single file change to remove SimpleDB from default config source
ipapapa commented 8 years ago

You are correct, we use system environmental variables for the region, so that is great!