Move Dynomite properties to DynomiteConfiguration and use Archaius; reorg code - Githubissues

Netflix / dynomite-manager

A sidecar to manage Dynomite clusters

https://github.com/Netflix/dynomite

Apache License 2.0

91 stars 59 forks source link

Move Dynomite properties to DynomiteConfiguration and use Archaius; reorg code #54

Closed akbarahmed closed 7 years ago

akbarahmed commented 7 years ago

PLEASE NOT NOT MERGE THIS PR YET...TESTING IS PENDING

This PR has been submitted to start a conversation. I still have to update unit tests and test the changes.

This PR does the following (across a larger number of small commits):

Break apart DynomitemanagerConfiguration by moving Dynomite specific fast properties into DynomiteConfiguration / DynomiteConfigurationRetriever.
Uses Archaius to get the configuration properties for Dynomite
Moves and renames legacy file locations to better match DM. (ex. rename TuneTask to DynomiteYamlTuneTask as it only does one thing, which is to write the dynomite.yaml file).

akbarahmed commented 7 years ago

Cancelled per conversation to centralize all configuration (FP) in DynomitemanagerConfiguration.