search

Netflix / dynomite-manager

A sidecar to manage Dynomite clusters
https://github.com/Netflix/dynomite
Apache License 2.0
91 stars 59 forks source link

Update configuration to use Archaius #60

Closed akbarahmed closed 7 years ago

akbarahmed commented 7 years ago

I am still pushing more updates into this PR. I will ping you when the PR is ready to be merged.

These updates are converting the remaining configuration to use Archaius.

akbarahmed commented 7 years ago

This PR is ready for review / merge.

There are approx. 48 more properties that need to be updated to use Archaius. I'll rebase and continue after this PR is merged.

ipapapa commented 7 years ago

LGTM - @shailesh33 let me know if you are OK to merge.

shailesh33 commented 7 years ago

Looks good to me. Thanks for answering.

On Sat, Nov 19, 2016 at 5:14 PM Akbar Ahmed notifications@github.com wrote:

@akbarahmed commented on this pull request.

In dynomitemanager/src/main/resources/dynomitemanager.properties https://github.com/Netflix/dynomite-manager/pull/60:

@@ -92,8 +92,14 @@ dm.dynomite.storage.preconnect=true

ENV: DM_DYNOMITE_MULTI_DC

dm.dynomite.multi.dc=true

-#florida.dyno.mbuf.size=16384 -#florida.dyno.allocated.messages=200000 +# Dynomite memory buffer (mbuf) size in bytes +# OLD: florida.dyno.mbuf.size=16384 +# ENV: DM_DYNOMITE_MBUF_SIZE +dm.dynomite.mbuf.size=16384

@shailesh33 https://github.com/shailesh33 We won't know unless we get complaints on GH issues.

However, I've been doing a good job of documenting the old vs. new property names in the dynomitemanager.properties https://github.com/DynomiteDB/dynomite-manager/blob/archaius_20161117/dynomitemanager/src/main/resources/dynomitemanager.properties file.

In the properties file I have 3 lines for each property:

  • OLD: the old property
  • ENV: the environment variable used to override the FP
  • then the new property

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Netflix/dynomite-manager/pull/60, or mute the thread https://github.com/notifications/unsubscribe-auth/ALle51PUsSQ-0C95TsSK8UDR-Sx9DheAks5q_58CgaJpZM4K2wbp .