search

Netflix / dynomite

A generic dynamo implementation for different k-v storage engines
Apache License 2.0
4.2k stars 533 forks source link

Dynomite and Redis integration driver for FastoNoSQL #621

Closed topilski closed 5 years ago

topilski commented 5 years ago

Hi, i found here https://github.com/Netflix/dynomite/blob/dev/notes/redis.md commands which dynomite support in Redis, i think i can implement driver for dynomite to show Redis content. is it a good idea? do you have some use cases when needed GUI for this solution?

ipapapa commented 5 years ago

Dynomite supports a subset of the vanilla Redis commands. What type of driver do you have in mind? We have an internal GUI that we have not yet open sourced (and we are not sure when). You can find some more information at this video. However, we would love to help you out if you want to create an OSS GUI.

topilski commented 5 years ago

Hi @ipapapa thank you for reply, we have 10 database drivers (FastoNoSQL slang, common interface wrap DB api) here sources https://github.com/fastogt/fastonosql_core/tree/master/src/core/db , in your case i think driver can be inharitance from https://github.com/fastogt/fastonosql_core/tree/master/src/core/db/redis_compatible which based on hiredis with ssh support , but commands count will be less than in common redis driver.

ipapapa commented 5 years ago

Correct. Note that Sentinel and Cluster commands are not relevant to us because Dynomite is multi-master and does not require external management systems.

topilski commented 5 years ago

Hi @ipapapa , i added DynomiteDB driver into FastoNoSQL here screenshot:

dynomitedb

It will be very cool if DynomiteDB have AUTH, SELECT, and DBSIZE implementation.

ipapapa commented 5 years ago

Awesome looks good. Note that DynomiteDB is a private company not currently associated with the project. Our OSS solution is called Dynomite. Currently, we only allow single DB that is why the SELECT command is not there. At some point, we are thinking of adding AUTH.

topilski commented 5 years ago

Hey @ipapapa thank you for reply, i will rename. Can i use this logo or need to change? Also how can i see DBSIZE not implemented?

ipapapa commented 5 years ago

I think the logo is not correct. You can find Dynomite's logo under images. I do not see any issue in adding DBSIZE. It should be fairly simple but would return the local copies size.

topilski commented 5 years ago

Hi @ipapapa , thank you for feedback, i updated resources and renamed driver. I will release FastoNoSQL on next Monday, also i will add links to Dynomite on our websites. Dynomite is very interesting solution, thank you for you job.