Fix building and linking with GCC 10

Netflix / dynomite

A generic dynamo implementation for different k-v storage engines

Apache License 2.0

4.2k stars 531 forks source link

Fix building and linking with GCC 10 #775

Open dmolik opened 4 years ago

dmolik commented 4 years ago

dyn_ring_queue.h defines 2 global variables that are used in many source files. This patch makes those variables ( C2G_InQ, C2G_OutQ ) external in the header, and intiates them in dyn_ring_queue.c

eskies commented 3 years ago

This fix helps me when building the Dynomite (Multiple definition errors both variables) on alpine Linux (ARM64 and AMD64). Glad found the solution here, thank you @dmolik

mcouillard commented 8 months ago

Wonderful, thank you! This also resolves the build on RHEL 9, GCC 11.