Netflix / dynomite

A generic dynamo implementation for different k-v storage engines
Apache License 2.0
4.19k stars 531 forks source link

Incorrect Privilege Assignment #804

Open ihsinme opened 2 years ago

ihsinme commented 2 years ago

https://github.com/Netflix/dynomite/blob/b56cf6a0e51a3c1941359da44af9e432c64b2f90/src/dynomite.c#L151

Good afternoon. I noticed that your code uses umask (0) with calls to open files without setting permissions. then your program will work with files with wide enough permissions and can, which can lead to security problems. I suggest to restrict access rights.