search

Netflix / edda

AWS API Read Cache
Apache License 2.0
568 stars 134 forks source link

Add ELB tags #102

Closed wstrucke closed 7 years ago

wstrucke commented 8 years ago

Hi! This patch has been working in our environment for a number of months but I recall now why I delayed in sending a pull request. It adds substantial load to the AWS API due to querying for tags on every ELB individually. I plan on altering it to perform batch requests to Amazon but haven't gotten around to implementing that yet.

brharrington commented 8 years ago

Might also be useful to have an option to disable it. Then users could choose if they want to have the additional calls.

hridyeshpant commented 7 years ago

@bradbenvenuti @wstrucke there are two new pull request, both are related to ELB. https://github.com/Netflix/edda/pull/117 --> adding pagination for elb crawler https://github.com/Netflix/edda/pull/112 --> Add support for elbv2 If someone can review/merge all these in single pull request, that will be great.

hridyeshpant commented 7 years ago

@wstrucke thanks for adding ELB tag part. could you pick the latest code which has "pagination for elb crawler"

117 --> adding pagination for elb crawler

Also could you address @brharrington comments as well?

brharrington commented 7 years ago

An option to disable the querying of tags can come later if someone has the time to create a PR. Minor changes have been addressed and conflicts resolved with master branch.