Aws cross account - Githubissues

Netflix / edda

AWS API Read Cache

Apache License 2.0

568 stars 134 forks source link

Aws cross account #121

Open sunder5 opened 7 years ago

brharrington commented 7 years ago

How is this different than #120? Can you provide a short description of the problem this change solves?

sunder5 commented 7 years ago

@brharrington Both #120 and #121 are same. Only differences between these two pull requests are AwsClient.scala. Using InstanceProfileCredentialsProvider to get credential details, if edda is running on EC2 instance.

ralph-tice commented 7 years ago

I started trying to review this but I don't think it's a reasonable approach. The AssumeRole functionality shouldn't bleed into every crawl implementation IMO.