Open sunder5 opened 7 years ago
@brharrington Both #120 and #121 are same. Only differences between these two pull requests are AwsClient.scala
. Using InstanceProfileCredentialsProvider
to get credential details, if edda is running on EC2
instance.
I started trying to review this but I don't think it's a reasonable approach. The AssumeRole functionality shouldn't bleed into every crawl implementation IMO.
How is this different than #120? Can you provide a short description of the problem this change solves?