Netflix / eureka

AWS Service registry for resilient mid-tier load balancing and failover.
Apache License 2.0
12.39k stars 3.74k forks source link

Add support for EIPs associated with secondary ENIs #1513

Closed brituck closed 10 months ago

brituck commented 1 year ago

Currently, Eureka client only supports registering EIPs that are directly associated to an instance and available via the root public-ipv4 IMDS key. This PR adds support to register an EIP that is attached via a secondary ENI. Due to the complexities of discovering and registering multiple public IPs for a single instance, we only register the first found public IP address. If an instance has both an EIP directly associated and and EIP associated via an ENI, the directly associated EIP will be registered. If the instance only has a EIP(s) associated via a ENI(s), the first found EIP will be registered. Additional use cases (i.e., registering multiple public IPv4 addresses) will not be supported.